Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) switch back to std hashmap [#279] #280

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

sunng87
Copy link
Owner

@sunng87 sunng87 commented Jul 18, 2019

Fixes #279

Benchmark shows std hashmap now shares same performance with hashbrown. So we'd better swtich back in next major release.

@sunng87 sunng87 added this to the 3.0 milestone Jul 22, 2019
@sondr3
Copy link

sondr3 commented Aug 23, 2019

FYI, hashbrown has become the std::hashmap implementation: rust-lang/rust#58623. This is probably why the performance is identical 😄

@sunng87 sunng87 merged commit 05c2659 into master Oct 29, 2019
@sunng87 sunng87 deleted the feature/switch-back-to-std-hashmap branch October 29, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with hashbrown 0.4 -> 0.5 upgrade
2 participants