Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for net8.0-ios #98

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Add support for net8.0-ios #98

merged 5 commits into from
Oct 18, 2024

Conversation

danardelean
Copy link
Contributor

This commit adds support for net8.0-ios to the library and the MauiApp test.

It will only work on the device (no support for iossimulator runtime) Supported runtime: ios-arm64

MauiApp - added the code to associate the first page image to the Image control

This commit addes support for net8.0-ios to the library and the MauiApp test. It will only work on the device (no support for iossimulator runtime)

MauiApp - added the code to associate the first page image to the Image control
@sungaila
Copy link
Owner

sungaila commented Oct 16, 2024

Have you tested this on a real iOS and iPadOS device?

With missing support for Mac Catalyst and simulated iOS, it's odd that iOS/iPadOS works "just like that".

I don't have hardware here to verify this so I have to take your word for it.

@sungaila sungaila self-assigned this Oct 16, 2024
@sungaila sungaila added the enhancement New feature or request label Oct 16, 2024
@danardelean
Copy link
Contributor Author

IMG_DDB98FEA8533-1

@danardelean
Copy link
Contributor Author

Of course the only thing that I'be tested and works is :
_bitmap = PDFtoImage.Conversion.ToImage(ms, 0);
I have to try to run all the tests on iOS and see if they pass

@sungaila
Copy link
Owner

Great, I will merge your pull request (after a few changes) and build a test version. Thanks for your help! :-)

@sungaila sungaila merged commit 44115ff into sungaila:master Oct 18, 2024
12 of 14 checks passed
@sungaila
Copy link
Owner

@danardelean I've released PDFtoImage 5.0.0-preview for testing. Please check if the iOS builds are still working if you have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants