Add support for user-supplied fragments config #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might come in handy if the user has custom docsets installed, that are not tracked by Kapeli's feed.
|
Good idea. 👍 I hadn't considered custom docsets for this feature. 🤔 I'll merge this after some clean up. |
sunaku
requested changes
Dec 5, 2018
| @@ -241,6 +253,14 @@ dasht-docsets "$@" | while read -r docset; do | |||
| fragment_by_docset["jQuery"] = "#content" | |||
| fragment_by_docset["jQuery_Mobile"] = "#content" | |||
| fragment_by_docset["jQuery_UI"] = "#content" | |||
|
|
|||
| if (fragments_conf != "") { | |||
| while (getline < fragments_conf) | |||
There was a problem hiding this comment.
We might avoid reading the fragments file here if it contents are passed in through -v option for awk.
There was a problem hiding this comment.
Unfortunately, my awk skills are really bad, so I have no idea how to archieve that. Sorry :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might come in handy if the user has custom docsets installed, that are not tracked by Kapeli's feed.