Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Web APIs section with examples #213

Merged
merged 6 commits into from
Jul 14, 2024

Conversation

srishti-coder
Copy link
Contributor

Summary

This pull request adds a new section titled "Web APIs" to the Learn JavaScript project. This section covers various Web APIs that are essential for modern JavaScript development.

Changes Made

  • Added a new section in the table of contents.
  • Created subsections for DOM Manipulation, Fetch API, Geolocation API, Canvas API, Storage API, and Notification API.
  • Included practical code examples for each Web API.

Benefits

  • Provides practical examples of using Web APIs.
  • Enhances learners' understanding of how to interact with the browser and web server.
  • Makes the curriculum more comprehensive and up-to-date with current JavaScript practices.

I look forward to feedback and suggestions. Thank you for reviewing my contribution.

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
learn-javascript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 11:41am

Copy link
Owner

@sumn2u sumn2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. The content are good but needs more explanation. Also, the markdown syntax is not used correctly.


## Introduction to Web APIs

Web APIs are interfaces provided by the browser that allow you to interact with the browser and the underlying operating system.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to give more context about Web APIs.

web-apis.md Outdated

### Example Code: Changing the Content of an Element

```document.getElementById("demo").innerHTML = "Hello, World!";```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to use the code syntax. An example on how to use it can be found here.
Screenshot 2024-07-02 at 9 20 11 PM

web-apis.md Outdated

```document.getElementById("demo").innerHTML = "Hello, World!";```

##Fetch API
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown syntax needs a space.

web-apis.md Outdated
###Example Code: Drawing Shapes on Canvas

```
var canvas = document.getElementById('myCanvas');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to use let or var in all place.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the markdown syntax is not correct here. I suggest looking at other chapters and previewing your work before pushing it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done the changes required. Do I have to mention the chapter name and page number as mentioned by other authors.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making changes. I see some merge conflicts. Can you fix it?

Regarding the chapter and page number. You can leave it to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will try.

fix merge conflicts
@sumn2u sumn2u merged commit c706e06 into sumn2u:main Jul 14, 2024
3 checks passed
@sumn2u
Copy link
Owner

sumn2u commented Jul 14, 2024

Nice work @srishti-coder 👏 .

@sumn2u
Copy link
Owner

sumn2u commented Jul 14, 2024

Fixes #212 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants