-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Web APIs section with examples #213
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. The content are good but needs more explanation. Also, the markdown syntax is not used correctly.
|
||
## Introduction to Web APIs | ||
|
||
Web APIs are interfaces provided by the browser that allow you to interact with the browser and the underlying operating system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to give more context about Web APIs.
web-apis.md
Outdated
|
||
### Example Code: Changing the Content of an Element | ||
|
||
```document.getElementById("demo").innerHTML = "Hello, World!";``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to use the code syntax. An example on how to use it can be found here.
web-apis.md
Outdated
|
||
```document.getElementById("demo").innerHTML = "Hello, World!";``` | ||
|
||
##Fetch API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown syntax needs a space.
web-apis.md
Outdated
###Example Code: Drawing Shapes on Canvas | ||
|
||
``` | ||
var canvas = document.getElementById('myCanvas'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to use let
or var
in all place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the markdown syntax is not correct here. I suggest looking at other chapters and previewing your work before pushing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done the changes required. Do I have to mention the chapter name and page number as mentioned by other authors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making changes. I see some merge conflicts. Can you fix it?
Regarding the chapter and page number. You can leave it to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will try.
fix merge conflicts
Nice work @srishti-coder 👏 . |
Fixes #212 . |
Summary
This pull request adds a new section titled "Web APIs" to the Learn JavaScript project. This section covers various Web APIs that are essential for modern JavaScript development.
Changes Made
Benefits
I look forward to feedback and suggestions. Thank you for reviewing my contribution.