Check for connection reset correctly #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type net.OpError embeds an os.SyscallError, which might hold the ECONNRESET value that is checked for.
This was referenced Aug 23, 2020
|
Hi! |
|
Handled via 9b53157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During ninenines/gun#241 I got an intermittent fault, that after a lot of tests boiled down to this correction.
It was usually test 6.5.1 that failed, and
connection reset by peerwas involved.The type net.OpError actually embeds the type os.SyscallError, which holds the ECONNRESET.
I also added a test to trigger the fault, and to verify the remedy. (verified using GithubActions both on ubuntu and windows)
The test uses real tcp sockets to get an exact behavior in this case, but using real sockets in tests might make people scream, so its optional and can be removed if wanted.
Thanks!