Fix panic in ledger exchange (#132)

* fix: prevent panic and improve trace * coins-ledger@0.9.3 * clippy
summa-tx · Jan 30, 2024 · 32463b1 · 32463b1
1 parent f8d200b
commit 32463b1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/bip32/src/path.rs b/bip32/src/path.rs
@@ -193,8 +193,7 @@ impl FromStr for DerivationPath {
     type Err = Bip32Error;
 
     fn from_str(s: &str) -> Result<Self, Self::Err> {
-        s.to_owned()
-            .split('/')
+        s.split('/')
             .filter(|v| v != &"m")
             .map(try_parse_index)
             .collect::<Result<Vec<u32>, Bip32Error>>()

diff --git a/ledger/Cargo.toml b/ledger/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "coins-ledger"
-version = "0.9.2"
+version = "0.9.3"
 authors = [
     "Summa <team@summa.one>",
     "James Prestwich <james@summa.one>",

diff --git a/ledger/src/transports/mod.rs b/ledger/src/transports/mod.rs
@@ -65,7 +65,7 @@ impl LedgerAsync for Ledger {
             Ok(resp) => {
                 debug!(
                     retcode = resp.retcode(),
-                    response = hex::encode(resp.data().unwrap()),
+                    response = resp.data().map(hex::encode),
                     "Received response from device"
                 )
             }