Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

was-seed viewer throws 500 when archived site URL isn't correct #1460

Closed
edsu opened this issue Feb 1, 2023 · 4 comments · Fixed by #1462
Closed

was-seed viewer throws 500 when archived site URL isn't correct #1460

edsu opened this issue Feb 1, 2023 · 4 comments · Fixed by #1462
Assignees

Comments

@edsu
Copy link
Contributor

edsu commented Feb 1, 2023

Expected behavior

When the PURL XML contains an archived website URL that isn't properly formatted then sul-embed should probably display something helpful about the problem?

Actual behavior

When the PURL XML contains an archived website URL that lacks a * it throws a 500 error:

Screenshot 2023-02-01 at 3 05 59 PM

Steps to reproduce the behavior

Load up some PURL XML for a was-seed object containing a URL like this into the sandbox viewer:

<location>
  <url displayLabel="Archived website">https://swap.stanford.edu/was/20220831210052/https://wexarts.org/talks-more/tongues-untied</url>
</location>

Browser / Environment

Firefox/MacOS

See sul-dlss/was_robot_suite#279 for related work to prevent was-seed objects from getting published with incorrect URLs.

@jcoyne
Copy link
Contributor

jcoyne commented Feb 1, 2023

@jcoyne jcoyne self-assigned this Feb 1, 2023
@jcoyne
Copy link
Contributor

jcoyne commented Feb 1, 2023

@edsu the purl for this item has https://swap.stanford.edu/was/20220831210052/https://wexarts.org/talks-more/tongues-untied as the archived URL. However, most archived urls that I've seen have a * in them. Should this be required?

jcoyne added a commit that referenced this issue Feb 1, 2023
jcoyne added a commit that referenced this issue Feb 1, 2023
jcoyne added a commit that referenced this issue Feb 1, 2023
@edsu
Copy link
Contributor Author

edsu commented Feb 1, 2023

Yes, it currently is required for the viewer to work, since it appears to be keying off the * to determine the Timemap URL to fetch to get the list of snapshots. Unfortunately there's nothing in the workflow to ensure that it is formatted correctly.

@jcoyne
Copy link
Contributor

jcoyne commented Apr 7, 2023

@edsu It's unclear to me what the action should be for this ticket? Is this something that can be fixed in data validation in cocina-models?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants