report MOAB_NOT_FOUND errors to honeybadger #1532
Conversation
| instance_double(Dor::Services::Client::Object, events: events_client) | ||
| ) | ||
| allow(Honeybadger).to receive(:notify).with(Regexp.new(hb_exp_msg)) | ||
| allow(events_client).to receive(:create).with(type: 'preservation_audit_failure', data: instance_of(Hash)) |
There was a problem hiding this comment.
i think the reporting functionality is pretty well tested, so this might not be worth it, but... what about putting these allow statements in the specific contexts for the MOAB_NOT_FOUND tests, so this fairly specific set of allows isn't applied to all the tests in this spec file? from a quick read through the spec file, this looks to me like the contexts on line 96 and line 456 would be the directly relevant ones. but if there are more, and this is onerous, i wouldn't hold up merge for it. though if you were up for trying it, and if it didn't work, i'd be curious about any other unexpected test failures.
(tangentially, i'm not sure why the context on line 456 (moab not found) is nested in the context on line 421 (catalog version > moab version), since the moab not being on disk seems to mean there is no version for the moab, but whatever, def outside the scope of this change, just a thing that surprised me slightly)
ndushay
force-pushed
the
moab-not-found-honeybadger-results
branch
from
01291ea to
717e50f
Compare
|
Code Climate has analyzed commit 717e50f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (97% is the threshold). This pull request will bring the total coverage in the repository to 98.1% (0.0% change). View more on Code Climate. |
ndushay
changed the title
[HOLD] - waiting for @jmartin-sul to ponder my comment ( #1483#issuecomment-627583503) on issue #1483Why was this change made?
To report MOAB_NOT_FOUND errors to Honeybadger.
Fixes #1483
Was the usage documentation (e.g. wiki, README, queue or DB specific README) updated?
na
Does this change affect how this application integrates with other services?
nope