Send preservationAuditWF events to the event service #1357
Comments
|
Yes, let's do this. |
|
splitting this into two tickets. this ticket is now just about sending events to the event service. there is a new (currently blocked, slightly ambiguous) ticket for un-coupling from |
jmartin-sul
changed the title
|
ah yes, had meant to close one or the other of this and #1351 as a dupe. but also i agree with @ndushay that the respective scopes of the two tickets differ slightly and that the wider scope of #1351 is what we want to do. as noted in #1363 (comment), de-coupling preservation from workflow service is a bit trickier than just sending events to the event service and somehow exposing audit errors -- we actually do want to block versioning if the preserved object has issues (even if that wasn't part of the original intent of sending errors to WFS). no preference as to which ticket gets kept open, now that this one has been updated with the relevant info. my gut feeling without really digging into the code again is that we want to push events from hopefully whatever work you've put into this so far can be extended to the slightly wider scope w/o too much trouble! |
Connects to sul-dlss/preservation_catalog#1357 Connects to sul-dlss/preservation_catalog#1351
Fixes #1357 Fixes #1351 This pull request sends audit results to the new DOR event service which is provided by dor-services-app. As part of this, I refactored the WorkflowReporter such that the class methods (all that was exposed previously) create an instance of the class, with the instance doing all the work. This preserves the prior contract and allows for less passing around of state which now lives in the instance.
Fixes #1357 Fixes #1351 This pull request sends audit results to the new DOR event service which is provided by dor-services-app. As part of this, I refactored the WorkflowReporter such that the class methods (all that was exposed previously) create an instance of the class, with the instance doing all the work. This preserves the prior contract and allows for less passing around of state which now lives in the instance.
Fixes #1357 Fixes #1351 This pull request sends audit results to the new DOR event service which is provided by dor-services-app. As part of this, I refactored the WorkflowReporter such that the class methods (all that was exposed previously) create an instance of the class, with the instance doing all the work. This preserves the prior contract and allows for less passing around of state which now lives in the instance.
Fixes #1357 Fixes #1351 This pull request sends audit results to the new DOR event service which is provided by dor-services-app. As part of this, I refactored the WorkflowReporter such that the class methods (all that was exposed previously) create an instance of the class, with the instance doing all the work. This preserves the prior contract and allows for less passing around of state which now lives in the instance.
Currently preservationAuditWF is not used as a workflow, but as a log of problems. It is not sending the object version, which is now a deprecated call in workflow_service_rails (https://app.honeybadger.io/projects/58890/faults/60031582). Can we change to use the event service in dor-services-app now?
The text was updated successfully, but these errors were encountered: