adjust job-id params and namespace for sending files to s3 #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
commented
Sep 27, 2024
| @cocina_object = cocina_object | ||
| @workflow_context = workflow_context | ||
| @bare_druid = cocina_object.externalIdentifier.delete_prefix('druid:') | ||
| @logger = logger || Logger.new($stdout) | ||
| end |
There was a problem hiding this comment.
this class never uses the logger, so remove for now unless we specifically need it later (it came as copypasta from the similar Ocr class)
peetucket
commented
Sep 27, 2024
| end | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def sttable_filenames | ||
| Dor::TextExtraction::SpeechToText.new(cocina_object:, workflow_context: workflow.context).filenames_to_stt | ||
| Dor::TextExtraction::SpeechToText.new(cocina_object:).filenames_to_stt |
There was a problem hiding this comment.
the filenames_to_stt method doesn't need workflow_context so don't bother passing it in
peetucket
force-pushed
the
1371-job-ids
branch
from
9ebbfc1
to
1fa3e60
Compare
peetucket
commented
Sep 27, 2024
| @@ -27,8 +27,7 @@ def perform_work | |||
| def send_sqs_message | |||
| message_body = { | |||
| id: job_id, | |||
| druid:, | |||
| media: | |||
| druid: | |||
There was a problem hiding this comment.
leaving the druid in the job message (even though it happens to be included in the job_id now) ... maybe useful for logging or other purposes to have it distinct
peetucket
force-pushed
the
1371-job-ids
branch
from
1fa3e60
to
7cb472c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made? 🤔
Fixes #1371 - job id is now druid-version and so is the place where we put the files in S3 bucket
How was this change tested? 🤨
Spec