♿(frontend) improve contrast for links #1232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/link-contrast-editor
branch
from
6d5a4de to
8e301df
Compare
Ovgodd
added a commit
that referenced
this pull request
Jul 28, 2025
Ovgodd
added a commit
that referenced
this pull request
Jul 28, 2025
updating Changelog.md with accessibility improvement
Ovgodd
force-pushed
the
fix/link-contrast-editor
branch
from
4e4d051 to
4d4665d
Compare
Ovgodd
added a commit
that referenced
this pull request
Jul 28, 2025
updating Changelog.md with accessibility improvement
Ovgodd
force-pushed
the
fix/link-contrast-editor
branch
from
4d4665d to
8ace624
Compare
Ovgodd
added a commit
that referenced
this pull request
Jul 28, 2025
updating Changelog.md with accessibility improvement
Ovgodd
force-pushed
the
fix/link-contrast-editor
branch
from
8ace624 to
e056a6c
Compare
Ovgodd
added a commit
that referenced
this pull request
Jul 28, 2025
updating Changelog.md with accessibility improvement
Ovgodd
force-pushed
the
fix/link-contrast-editor
branch
from
e056a6c to
5cd7909
Compare
Updated anchor link color from greyscale-500 to greyscale-600
Ovgodd
added a commit
that referenced
this pull request
Jul 28, 2025
updating Changelog.md with accessibility improvement
Ovgodd
force-pushed
the
fix/link-contrast-editor
branch
2 times, most recently
from
04b66ae to
7021c0f
Compare
updating Changelog.md with accessibility improvement
Closed
Ovgodd
added a commit
that referenced
this pull request
Jul 29, 2025
Add a note in the changelog to document frontend accessibility improvements Signed-off-by: Cyril <c.gromoff@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve text accessibility by enhancing the contrast of links on colored backgrounds.
issue 1171
Proposal
Changed link color from greyscale-500 to greyscale-600 to make it easier to read on colored backgrounds as suggested in the issue
.
Tried to fix the case where text color === background color (like red on red) using CSS overrides.
But it didn’t work, because BlockNote.js uses inline styles that are too strong to override.
We may need to fix this directly inside BlockNote.js to allow better control of contrast for colored texts.l
External contributions
Thank you for your contribution! 🎉
Please ensure the following items are checked before submitting your pull request:
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description## [Unreleased]section (if noticeable change)