Skip to content

🐛(service-worker) Fix useOffline Maximum update depth exceeded #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

🐛(service-worker) Fix useOffline Maximum update depth exceeded #1196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,20 @@ and this project adheres to

## [Unreleased]

## Fixed
### Changed

- 🔧(project) change env.d system by using local files #1200

### Fixed

- 🐛(service-worker) Fix useOffline Maximum update depth exceeded #1196
- 🐛(helm) charts generate invalid YAML for collaboration API / WS #890

## [3.4.2] - 2025-07-18

### Changed

- ⚡️(docker) Optimize Dockerfile to use apk with --no-cache #743
- 🔧(project) change env.d system by using local files #1200

### Fixed

Expand Down
10 changes: 7 additions & 3 deletions src/frontend/apps/impress/src/features/service-worker/hooks/useOffline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,17 @@ interface IsOfflineState {
setIsOffline: (value: boolean) => void;
}

export const useIsOffline = create<IsOfflineState>((set) => ({
export const useIsOffline = create<IsOfflineState>((set, get) => ({
isOffline: typeof navigator !== 'undefined' && !navigator.onLine,
setIsOffline: (value: boolean) => set({ isOffline: value }),
setIsOffline: (value: boolean) => {
if (get().isOffline !== value) {
set({ isOffline: value });
}
},
}));

export const useOffline = () => {
const { setIsOffline } = useIsOffline();
const setIsOffline = useIsOffline((state) => state.setIsOffline);

useEffect(() => {
const handleMessage = (event: MessageEvent<OfflineMessageData>) => {
Expand Down
Loading