Extend stylelint peerDep #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like stylelint was updated in the devDependencies without also updating the peerDependencies. This means that while this project is set up and tested using stylelint 15, projects that use this project can't use stylelint 15 and have to use 14 (at least without warnings from npm). This change extends the stylelint peerDependency version range to include 15. An alternative path would be to change the peerDependency to _only_ support stylelint 15, if you don't intend to continue testing with stylelint 14, although this would be a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like stylelint was updated in the devDependencies without also updating the peerDependencies. This means that while this project is set up and tested using stylelint 15, projects that use this project can't use stylelint 15; they have to use 14.
This change extends the stylelint peerDependency version range to include 15. An alternative path would be to change the peerDependency to only support stylelint 15, if you don't intend to continue testing with stylelint 14, although this would be a breaking change.