Support process SOAP 1.2 reply #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. Can you please add a test covering this
behavior?
…On Sat, Dec 23, 2023 at 11:38 AM eshizhan ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#96
Commit Summary
- 82284f7
<82284f7>
Support process SOAP 1.2 reply
File Changes
(1 file <https://github.com/suds-community/suds/pull/96/files>)
- *M* suds/bindings/binding.py
<https://github.com/suds-community/suds/pull/96/files#diff-159b09ba36fa01f4e20cb4d91b8fdf65b3e07f3ce0dacc3e9b7d061588d9b02e>
(5)
Patch Links:
- https://github.com/suds-community/suds/pull/96.patch
- https://github.com/suds-community/suds/pull/96.diff
—
Reply to this email directly, view it on GitHub
<#96>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXCKKRCW5FRDFABZP3PXLYK4CHBAVCNFSM6AAAAABBA4YSFOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TIOBTG44DSMI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@phillbaker add test case, thx for review! |
|
Hi, it looks like the test suite is failing on CI. Can you take a look at
the failing tests?
…On Sun, Dec 24, 2023 at 10:10 PM eshizhan ***@***.***> wrote:
@phillbaker <https://github.com/phillbaker> add test case, thx for review!
—
Reply to this email directly, view it on GitHub
<#96 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXCKN7ICAE2OLWEACHB6DYLDVDDAVCNFSM6AAAAABBA4YSFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGY4TCOBWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I saw it, but these failures have nothing to do with this PR. I think these failures seem to be related to pytest in the CI environment. |
|
The reason is |
|
Thanks, I’ll check it out.
…On Mon, Dec 25, 2023 at 9:47 AM eshizhan ***@***.***> wrote:
The reason is 3.x bump to 3.12, it's remove distutils module.
—
Reply to this email directly, view it on GitHub
<#96 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXCKLDB77MFC254MYZJ4TYLGGXVAVCNFSM6AAAAABBA4YSFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGAYTIMBSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sorry for the slow update here, fixes have been merged to master to fix python 3.12, can you rebase your branch please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.