Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed notifications if the user's machine was powered on after the scheduled time had past #50

Merged
merged 5 commits into from
Oct 14, 2022

Conversation

QueTeddy
Copy link
Contributor

@QueTeddy QueTeddy commented Oct 11, 2022

Added notifications

@QueTeddy QueTeddy marked this pull request as ready for review October 11, 2022 07:10
Copy link
Owner

@sudiptob2 sudiptob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggested some changes 🙏
Also, please rename your branch and add proper commit messages according to the contributing guidelines

leeteasy/__main__.py Outdated Show resolved Hide resolved
leeteasy/__main__.py Outdated Show resolved Hide resolved
Copy link
Owner

@sudiptob2 sudiptob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine, can you run the .github/check.sh script and confirm that it doesn't give any code quality error? 🙏

@QueTeddy
Copy link
Contributor Author

I ran the check and it came out clean. Could I ask what the check.sh script does and how?

Could you point me to any documentation that might help? Thanks

@sudiptob2
Copy link
Owner

I ran the check and it came out clean. Could I ask what the check.sh script does and how?

Could you point me to any documentation that might help? Thanks

Great, it actually checks several things,

  1. run unit tests
  2. flake8 checks
  3. mypy checks

Actually now, I asked you to run it manually but I will set up a GitHub action so that when anyone create a PR it will run automatically by GitHub, and merge will be blocked if there are any errors.

@QueTeddy
Copy link
Contributor Author

Okay thanks, I would read more on the type of checking as I could see static and dynamic.

Could you merge the PR?

@sudiptob2
Copy link
Owner

Okay thanks, I would read more on the type of checking as I could see static and dynamic.

Could you merge the PR?

will merge it shortly

@QueTeddy
Copy link
Contributor Author

Are there any other problems you would like me to have a look at?

The experience was very nice.

@sudiptob2
Copy link
Owner

Thanks 😊 follow me on github/twitter/linkedin for future opensouce projects 🙏

@sudiptob2 sudiptob2 marked this pull request as draft October 13, 2022 05:13
@sudiptob2 sudiptob2 marked this pull request as ready for review October 13, 2022 05:13
@sudiptob2
Copy link
Owner

hi @QueTeddy, it seems that there is some problems in your code and cached by the chek.sh script. please fix that 🙏

@sudiptob2 sudiptob2 marked this pull request as draft October 13, 2022 05:19
leeteasy/__main__.py Outdated Show resolved Hide resolved
@sudiptob2 sudiptob2 marked this pull request as ready for review October 14, 2022 17:28
@sudiptob2 sudiptob2 self-requested a review October 14, 2022 17:31
@sudiptob2 sudiptob2 marked this pull request as draft October 14, 2022 18:19
@sudiptob2 sudiptob2 marked this pull request as ready for review October 14, 2022 18:19
leeteasy/__main__.py Outdated Show resolved Hide resolved
leeteasy/__main__.py Show resolved Hide resolved
@sudiptob2 sudiptob2 merged commit 78d06ee into sudiptob2:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants