-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed notifications if the user's machine was powered on after the scheduled time had past #50
Conversation
…heduled time had past
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have suggested some changes 🙏
Also, please rename your branch and add proper commit messages according to the contributing guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine, can you run the .github/check.sh
script and confirm that it doesn't give any code quality error? 🙏
I ran the check and it came out clean. Could I ask what the check.sh script does and how? Could you point me to any documentation that might help? Thanks |
Great, it actually checks several things,
Actually now, I asked you to run it manually but I will set up a GitHub action so that when anyone create a PR it will run automatically by GitHub, and merge will be blocked if there are any errors. |
Okay thanks, I would read more on the type of checking as I could see static and dynamic. Could you merge the PR? |
will merge it shortly |
Are there any other problems you would like me to have a look at? The experience was very nice. |
Thanks 😊 follow me on github/twitter/linkedin for future opensouce projects 🙏 |
hi @QueTeddy, it seems that there is some problems in your code and cached by the |
Added notifications