Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#31] test: add tests for TimeValidator #37

Merged
merged 3 commits into from
Oct 13, 2022
Merged

[#31] test: add tests for TimeValidator #37

merged 3 commits into from
Oct 13, 2022

Conversation

Chaitanya134
Copy link
Contributor

@Chaitanya134 Chaitanya134 commented Oct 4, 2022 •
edited by sudiptob2
Loading

Added Tests for TimeValidator's validator method

closes #31

sudiptob2
sudiptob2 requested changes Oct 5, 2022
View reviewed changes
Copy link
Owner

@sudiptob2 sudiptob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for the PR 🙏

  • I am already using pytest, can you please use pytest for writing your test cases?

    you can use with pytest.raises(SystemExit): in pytest.

  • Also could you please rename folder tests/validator into tests/test_validator 👍

@Chaitanya134
Copy link
Contributor Author

Did the changes :)
Kindly review
Haven't used pytest before so I don't know if this is fine

@sudiptob2
Copy link
Owner

Hey, seems OK for now 🚀 But some of my own tests are broken, I need to fix those. Also, I am gonna implement a CI pipeline to run these tests and some additional code quality checks. I think it is high time I implement that. So please give me a couple of days and I will review your changes and possibly merge if everything is OK 🙏

@Chaitanya134
Copy link
Contributor Author

Sure :)

@sudiptob2
Copy link
Owner

sudiptob2 commented Oct 8, 2022 •
edited
Loading

I have implemented a script check.sh for code quality check and all. can you please check your changes with that 🙏 you will find it in .github/check.sh @Chaitanya134

@sudiptob2 sudiptob2 marked this pull request as draft October 13, 2022 17:09
@sudiptob2 sudiptob2 marked this pull request as ready for review October 13, 2022 17:10
@sudiptob2 sudiptob2 marked this pull request as draft October 13, 2022 17:13
@sudiptob2 sudiptob2 marked this pull request as ready for review October 13, 2022 17:13
@sudiptob2 sudiptob2 merged commit 8d0209b into sudiptob2:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudiptob2 sudiptob2 sudiptob2 approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted hactoberfest2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add unit tests for TimeValidator methods
2 participants
@Chaitanya134 @sudiptob2