chore: unpin curve25519 #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 16, 2024
|
There were some issues with the Closing this in favor of: #370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, libraries should have as permissive dependencies as possible. The previous change to =pin curve25519 meant that plonky2x was incompatible with a few dependencies, particularly those that make use of ed25519. With this change, it would allow use to make use of
cargofor semver compatibility, and any security issues going forward would not need a codechange from the upstream maintainers, just acargo update --recursive -p plonky2x.I couldn't see any related CVEs with regard to dalek cryptography recently, the last one being in October which was fixed in a revision release.