Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is an edit; the first attempt was slightly too optimistic. 🙈
The circuit was implemented by combining Jump's keccak256 circuit with Kevin's work, removing shared hash components, and integrating the circuit "front-end" with the Succinct X "back-end." A few questions remain:
Most notably, it seems we want to constrain the front-end to accept only an array of bytes (as indicated in
circuit.go
). If this is the agreed-upon standard for passing inputs into hashing circuits, this PR requires some tweaks to be compliant.Currently, the circuit has the following characteristics: