Split the shift ALU table into left and right #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevjue
reviewed
Jan 9, 2024
There was a problem hiding this comment.
In general, LGTM.
I think one thing to consider is since there is a lot of common code, maybe consider creating a trait (perhaps with generics) and then having the right shift and left shift chip implement the trait.
And seems like that might be applicable to other related structs as well, like LeftShiftCols and RightShiftCols.
|
If you think this is a long-term change, can you move it to alu/srl and alu/sll? That would be more consistent with the rest of the codebase like |
|
Also, the column names should be consistent with the Opcode--it's "ShiftLeft" not "LeftShift". |
jtguibas
approved these changes
Jan 9, 2024
jtguibas
pushed a commit
that referenced
this pull request
Mar 29, 2024
jtguibas
pushed a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.