fix: update SHA2 dependency reference and clean up TODOs #2130
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Cargo.toml file contained an incorrect reference to
sha2-v0-9-8, while the actual version used was0.9.9. Additionally, outdated comments regarding the yanked status of0.9.8were still present, causing potential confusion. This PR ensures consistency in dependency definitions and removes misleading information.Checked the
sha2crate versions on crates.io and confirmed that version 0.9.8 is yanked.Solution
sha2-v0-9-8 = { version = "0.9.9", package = "sha2" }tosha2-v0-9-9 = { version = "0.9.9", package = "sha2" }to properly reflect the correct version reference.0.9.8being yanked.