Skip to content

Commit

Permalink
feat: add sp1-sdk tests with SP1_DEV=0 for release ci (#694)
Browse files Browse the repository at this point in the history
  • Loading branch information
jtguibas authored May 10, 2024
1 parent 3b4d950 commit 1c85390
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 6 deletions.
26 changes: 25 additions & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -137,4 +137,28 @@ jobs:
- name: Run cargo check
run: |
RUSTFLAGS="-Copt-level=3 -Cdebug-assertions -Coverflow-checks=y -Cdebuginfo=0 -C target-cpu=native" \
cargo check --manifest-path examples/Cargo.toml --all-targets --all-features
cargo check --manifest-path examples/Cargo.toml --all-targets --all-features
template:
name: Examples
runs-on: runs-on,runner=8cpu-linux-x64
env:
CARGO_NET_GIT_FETCH_WITH_CLI: "true"
steps:
- name: Checkout sources
uses: actions/checkout@v2

- name: Setup CI
uses: ./.github/actions/setup

- name: Install SP1 toolchain
run: |
curl -L https://sp1.succinct.xyz | bash
~/.sp1/bin/sp1up
~/.sp1/bin/cargo-prove prove --version
- name: Install SP1 CLI
run: |
cd cli
cargo install --locked --path .
cd ~
15 changes: 11 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ env:
jobs:
prepare:
name: Prepare release
runs-on: ubuntu-latest
runs-on: runner=64cpu-linux-arm64
timeout-minutes: 30
outputs:
tag_name: ${{ steps.release_info.outputs.tag_name }}
Expand All @@ -33,6 +33,16 @@ jobs:
with:
pull_token: ${{ secrets.PULL_TOKEN }}

- name: Run cargo test
uses: actions-rs/cargo@v1
with:
command: test
toolchain: nightly-2024-04-17
args: -p sp1-sdk --release -- --nocapture
env:
RUSTFLAGS: -Copt-level=3 -Cdebug-assertions -Coverflow-checks=y -Cdebuginfo=0 -C target-cpu=native
RUST_BACKTRACE: 1

- name: Compute release name and tag
id: release_info
run: |
Expand Down Expand Up @@ -68,9 +78,6 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}




release:
name: ${{ matrix.target }} (${{ matrix.runner }})
runs-on: ${{ matrix.runner }}
Expand Down
2 changes: 1 addition & 1 deletion sdk/src/artifacts.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ pub use sp1_prover::build::{build_groth16_artifacts_with_dummy, get_groth16_arti
pub fn export_solidity_groth16_verifier(output_dir: impl Into<PathBuf>) -> Result<()> {
let output_dir: PathBuf = output_dir.into();
let artifacts_dir = sp1_prover::build::get_groth16_artifacts_dir();
let verifier_path = artifacts_dir.join("Groth16Verifier.sol");
let verifier_path = artifacts_dir.join("SP1Verifier.sol");

if !verifier_path.exists() {
return Err(anyhow::anyhow!(
Expand Down

0 comments on commit 1c85390

Please sign in to comment.