Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release build failing #108

Open
jacques-n opened this issue Nov 25, 2022 · 9 comments · Fixed by #110
Open

Release build failing #108

jacques-n opened this issue Nov 25, 2022 · 9 comments · Fixed by #110

Comments

@jacques-n
Copy link
Collaborator

I merged the release patch it looks like the release build is failing.

Additionally, it looks like it is tagging version on each merge (maybe) as opposed to once a week...

Failure here: https://github.com/substrait-io/substrait-java/actions/runs/3544635664/jobs/5952198598

@davisusanibar, can you take a look?

@davisusanibar
Copy link
Contributor

Let me check that

davisusanibar added a commit to davisusanibar/substrait-java that referenced this issue Nov 25, 2022
@davisusanibar
Copy link
Contributor

Just to mention:

  • Building error: Solved by upgrade gradlew version.
  • Tagging version: It was implemented to deploy immediately after a PR is merged (Is it necessary to wait/concatenate features to release then?). Changed to deploy 2 AM on Sunday or manually.

For testing purpose, please help me to run release job to test if it is working, thanks.

@davisusanibar
Copy link
Contributor

Hi @jacques-n / @westonpace

I'am seeing this error message on the release: https://github.com/substrait-io/substrait-java/actions/runs/3550260556/jobs/5963588183

* What went wrong:
Could not evaluate onlyIf predicate for task ':core:signMaven-publishPublication'.
> Could not read PGP secret key

Could you try to run Sanity Check Environment to test secrets configuration?

@jacques-n
Copy link
Collaborator Author

Reopening as the release is still failing.

@jacques-n jacques-n reopened this Nov 25, 2022
@jacques-n
Copy link
Collaborator Author

@davisusanibar
Copy link
Contributor

Please update secret value for SIGNING_KEY

SIGNING_KEY needs to be generated with this command line: gpg --export-secret-keys C8BA52B3 | base64

As the message mention base64: invalid input I could suggest that the current value is invalid, please in case this was created with gpg --export-secret-keys --armor C8BA52B3, please change to use base64 command line mentioned.

@westonpace / @jacques-n

@westonpace
Copy link
Member

Yes, I had exported the key in --armor format (I think this is what Sonatype wants). Either way, I have updated they key to be base64 encoded non-armor. The sanity script now passes. The release script failed because the signing key was invalid. It wanted an 8-digit signing key. I had included the full signing key. I have changed the signing key secret to the short key.

This is ready to run again.

However, semantic release refuses to create a release because it doesn't see any changes.

So we will either need to create a dummy commit or wait for a change.

@davisusanibar
Copy link
Contributor

An option could be to review #104 that is related with promote version from Staging to Production after 14 days old, and use that to test semantic-release process.

@davisusanibar
Copy link
Contributor

baibaichen pushed a commit to baibaichen/substrait-java that referenced this issue Feb 6, 2023
* add native block support

* ch shuffle init

* fix shuffle problem

* recover coalesce exec

* add coalesce operator

* fix memory double free

* add ColumnarFactory

* add some metrics

* fix rename package name error

* remove log

* remove print

* add config default value
ajegou pushed a commit to ajegou/substrait-java that referenced this issue Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants