Initial commit of substrait-cpp #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to can't re-open PR for #1, so create this new PR |
westonpace
requested changes
Nov 8, 2022
|
Thanks for addressing my earlier comments. I made another pass today and appreciate all the work! 😃 |
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
@westonpace, Thank you for your patience to reviewing again, and I have updated this PR according your reviews. |
westonpace
approved these changes
Dec 11, 2022
Comment on lines
+44
to
+50
| void addScalarFunctionVariant(const FunctionImplementationPtr& functionVariant); | ||
|
|
||
| /// Add a aggregate function variant. | ||
| void addAggregateFunctionVariant(const FunctionImplementationPtr& functionVariant); | ||
|
|
||
| /// Add a window function variant. | ||
| void addWindowFunctionVariant(const FunctionImplementationPtr& functionVariant); |
There was a problem hiding this comment.
We should probably rename all these addXyzVariant to addXyzImplementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an Initial commit of substrait-cpp which includes following features: