-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use fresh instance on each new plugin invocation #413
Conversation
@ospencer You're failing in CI:
|
@javorszky Any chance you can figure out the CI failure? |
Other recent PRs also show the same error, so this PR isn't the cause. We should review + merge independently of diagnosing that test failure. |
Tracking the CI failure in #414 |
the fun thing is that the same issue does not appear on my local when I run make test. When running the one test function from inside goland, it does happen though. Weird. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made two small changes on top of what the original PR was:
- skipping a test that depends on external something outside of our control (1password error page)
- passing in instance into deferred function and using a differently named variable inside the function to better separate scopes and guard against shadowing
Porting this fix from suborbital/sat#179