Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated backport of #2399: Fix race when out-of-order RemoteEndpoint events are seen #2430

Conversation

sridhargaddam
Copy link
Member

Backport of #2399 on release-0.13.

#2399: Fix race when out-of-order RemoteEndpoint events are seen

For details on the backport process, see the backport requests page.

When there is a gateway migration in a remote cluster or if there
is any stale endpoint on the Broker associated with the remoteCluster,
the events might come in out of order which can create issues for
datapath connectivity. The existing code was already having checks
to ignore stale endpoint notifications in the kubeproxy and OVN handler.
However, similar check was missing in MTU handler and an issue was
seen in one of the environments. This PR moves the checks to the
event handler framework and removes them from the registered handlers
so that the fix will apply to all the handlers.

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2430/sridhargaddam/automated-backport-of-#2399-origin-release-0.13
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@nyechiel
Copy link
Member

@sridhargaddam any idea why E2E was failing here?

@tpantelis tpantelis enabled auto-merge (rebase) April 18, 2023 11:54
@sridhargaddam
Copy link
Member Author

@sridhargaddam any idea why E2E was failing here?

Which one?

@nyechiel
Copy link
Member

@sridhargaddam any idea why E2E was failing here?

Which one?

mm I am pretty sure https://github.com/submariner-io/submariner/actions/runs/4731824505/jobs/8397222931?pr=2430 was failing, but is shown as "skipped" now?

@sridhargaddam
Copy link
Member Author

@sridhargaddam any idea why E2E was failing here?

Which one?

mm I am pretty sure https://github.com/submariner-io/submariner/actions/runs/4731824505/jobs/8397222931?pr=2430 was failing, but is shown as "skipped" now?

Okay, triggered a re-run. Lets see 👍

@sridhargaddam
Copy link
Member Author

@dfarrell07 @tpantelis the E2e job is getting skipped. Any idea why?

@tpantelis
Copy link
Contributor

tpantelis commented Apr 18, 2023

@dfarrell07 @tpantelis the E2e job is getting skipped. Any idea why?

E2E Full - b/c it needs 2 approvers or ready-to-test 😄

@nyechiel nyechiel added the ready-to-test When a PR is ready for full E2E testing label Apr 18, 2023
@tpantelis tpantelis merged commit 06258c7 into submariner-io:release-0.13 Apr 18, 2023
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2430/sridhargaddam/automated-backport-of-#2399-origin-release-0.13]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-backport ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants