Some questions about lighthouse dns?

[zcz-1020]

Recently, I was looking at the lighthouse dns source-code and had some questions about the getClusterIPForSvc method of record.go。

func (lh *Lighthouse) getClusterIPForSvc(pReq *recordRequest) (*serviceimport.DNSRecord, bool) {
	localClusterID := lh.ClusterStatus.LocalClusterID()

	record, found, isLocal := lh.ServiceImports.GetIP(pReq.namespace, pReq.service, pReq.cluster, localClusterID, lh.ClusterStatus.IsConnected,
		lh.EndpointsStatus.IsHealthy)

	getLocal := isLocal || pReq.cluster != "" && pReq.cluster == localClusterID
	if found && getLocal {
		record, found = lh.LocalServices.GetIP(pReq.service, pReq.namespace)
	}

	return record, found
}

When both found and getLocal are true (that is, the serviceimport service on the local cluster is parsed) . Why do we still need to use localServices.GetIP to parse the IP address on the local cluster?

[sridhargaddam]

When an exported service is present even on the local cluster, Lighthouse will give local service precedence over the remote service.

[sridhargaddam]

You can refer to this PR for more details - #355

[zcz-1020]

Thank you. I see. I didn't think about globalnet is enabled before.