Remove fake.DynamicClient in favor of using the various fake Reactors #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
Oats87,
skitt and
sridhargaddam
as code owners
|
🤖 Created branch: z_pr796/tpantelis/rem_fake_dyn_client |
aswinsuryan
approved these changes
Nov 17, 2023
The functionality provided by fake.DynamicClient is replaced by the FailingReactor et al. Fixes submariner-io#689 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
force-pushed
the
rem_fake_dyn_client
branch
from
db7a462 to
01622af
Compare
sridhargaddam
approved these changes
Nov 17, 2023
|
🤖 Closed branches: [z_pr796/tpantelis/rem_fake_dyn_client] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality provided by
fake.DynamicClientis replaced by theFailingReactoret al.Fixes #689