Change ForDynamic to proper generic type *Unstructured #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
Oats87,
skitt and
sridhargaddam
as code owners
|
🤖 Created branch: z_pr795/tpantelis/for_dynamic |
tpantelis
force-pushed
the
for_dynamic
branch
2 times, most recently
from
40fe4d7 to
aaca26a
Compare
skitt
reviewed
Nov 16, 2023
tpantelis
force-pushed
the
for_dynamic
branch
from
aaca26a to
72e3ce5
Compare
skitt
approved these changes
Nov 16, 2023
yeah I changed submariner and lighthouse locally. |
aswinsuryan
approved these changes
Nov 17, 2023
tpantelis
force-pushed
the
for_dynamic
branch
from
72e3ce5 to
c27b1cf
Compare
...instead of runtime.Object, which I think was used originally to preserve the behavior of allowing any runtime.Object and internally converting to *Unstructured but we can easily adjust users accordingly. Some resource syncer unit tests failed b/c previously ForDynamic had the side effect of actually modifying the resource on Update and the tests did not explicitly retrieve the updated resource after test.UpdateResource. The fake Federator was also modified to internally convert to *Unstructured to simplify users. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
force-pushed
the
for_dynamic
branch
from
c27b1cf to
4a78c6e
Compare
|
🤖 Closed branches: [z_pr795/tpantelis/for_dynamic] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of
runtime.Object, which I think was used originally to preserve the behavior of allowing anyruntime.Objectand internally converting to*Unstructuredbut we can easily adjust users accordingly.Some resource syncer unit tests failed b/c previously
ForDynamichad the side effect of actually modifying the resource onUpdateand the tests did not explicitly retrieve the updated resource aftertest.UpdateResource. The fakeFederatorwas also modified to internally convert to*Unstructuredto simplify users.