EnsureValidName should strip leading or trailing dash

EnsureValidName converts all invalid chars to a dash ('-') but
that could leave a leading or trailing dash which is invalid so
just strip a leading or trailing dash.

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

pkg/resource/resource_test.go

@@ -43,10 +43,19 @@ var _ = Describe("EnsureValidName", func() {
 	})
 
 	When("the string has non-alphanumeric letters", func() {
-		It("should convert them approriately", func() {
+		It("should convert them appropriately", func() {
 			Expect(resource.EnsureValidName("no-!@*()#$-chars")).To(Equal("no---------chars"))
 		})
 	})
+
+	When("the string starts or ends with an invalid char", func() {
+		It("should strip the char", func() {
+			Expect(resource.EnsureValidName("-abc")).To(Equal("abc"))
+			Expect(resource.EnsureValidName("abc-")).To(Equal("abc"))
+			Expect(resource.EnsureValidName("-abc-")).To(Equal("abc"))
+			Expect(resource.EnsureValidName("%abc*")).To(Equal("abc"))
+		})
+	})
 })
 
 var _ = Describe("TrimManagedFields", func() {

pkg/resource/util.go

@@ -111,14 +111,16 @@ func MustToMeta(obj interface{}) metav1.Object {
 func EnsureValidName(name string) string {
 	// K8s only allows lower case alphanumeric characters, '-' or '.'. Regex used for validation is
 	// '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*'
-	return strings.Map(func(c rune) rune {
+	name = strings.Map(func(c rune) rune {
 		c = unicode.ToLower(c)
 		if !unicode.IsDigit(c) && !unicode.IsLower(c) && c != '-' && c != '.' {
 			return '-'
 		}
 
 		return c
 	}, name)
+
+	return strings.Trim(name, "-")
 }
 
 func ToJSON(o any) string {