fix: additional paths shouldn't be duplicated every time a new session starts #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfcherng
commented
Jun 13, 2024
jfcherng
force-pushed
the
fix/duplicated-path-env
branch
from
d948383 to
8a89ce4
Compare
… starts Signed-off-by: Jack Cherng <jfcherng@gmail.com>
|
Unit test failures are irrelevant to this PR. |
rchl
reviewed
Jun 14, 2024
rchl
reviewed
Jun 14, 2024
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
jfcherng
force-pushed
the
fix/duplicated-path-env
branch
from
13d4fe7 to
254547b
Compare
rchl
reviewed
Jun 14, 2024
rchl
reviewed
Jun 14, 2024
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configuration.env['PATH']is bound to a server class and we just keep prepending the same additional paths into it every time when there is a new session starts (e.g., a project is opened in a new window). Eventually, it triggers this bug: TerminalFi/LSP-copilot#163