Fix failing python 3.8 unittests on MacOS #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adopts `unittesting.ViewTestCase` to run view related test cases. ViewTestCase ... 1. provides `view` and `window` members pointing to a dedicated view, being created for testing. 2. ensures not to close empty windows, which was probably the most likely reason for unittests failing before on MacOS.
deathaxe
changed the title
|
Note: Various test cases don't seem to properly create dedicated windows for testing. I therefore managed to destroy my open workspace due to running LSP unittests locally. |
predragnikolic
force-pushed
the
feat/py38
branch
from
2f64b33 to
20f8fc8
Compare
predragnikolic
approved these changes
Mar 24, 2024
There was a problem hiding this comment.
Thanks,
I left this comment here https://github.com/sublimelsp/LSP/pull/2436/files#r1536919851
If we conclude that the order needs to be as it was, I will change it my PR.
Merged
predragnikolic
added a commit
that referenced
this pull request
Apr 19, 2024
* "Add .python-version file" * remove pathlib from dependencies * change import * Revert "change import" (: This reverts commit c70cd57. * Fix failing unittests on MacOS (#2436) This commit adopts `unittesting.ViewTestCase` to run view related test cases. ViewTestCase ... 1. provides `view` and `window` members pointing to a dedicated view, being created for testing. 2. ensures not to close empty windows, which was probably the most likely reason for unittests failing before on MacOS. * keep the same order as before * rchlint * add release notes * tweak release message * Be more descriptive of what the user expect, or what the user can do if things go wrong * tweak words * fix typos --------- Co-authored-by: Rafal Chlodnicki <rafal@squareup.com> Co-authored-by: deathaxe <deathaxe82@googlemail.com> Co-authored-by: Raoul Wols <raoulwols@gmail.com> Co-authored-by: Predrag <predrag@Predrags-Laptop.local>
predragnikolic
added a commit
that referenced
this pull request
Apr 20, 2024
* "Add .python-version file" * remove pathlib from dependencies * change import * Revert "change import" (: This reverts commit c70cd57. * Fix failing unittests on MacOS (#2436) This commit adopts `unittesting.ViewTestCase` to run view related test cases. ViewTestCase ... 1. provides `view` and `window` members pointing to a dedicated view, being created for testing. 2. ensures not to close empty windows, which was probably the most likely reason for unittests failing before on MacOS. * keep the same order as before * rchlint * add release notes * tweak release message * Be more descriptive of what the user expect, or what the user can do if things go wrong * tweak words * Use variable annotations instead of type comments --------- Co-authored-by: Предраг Николић <idmpepe@gmail.com> Co-authored-by: Rafal Chlodnicki <rafal@squareup.com> Co-authored-by: deathaxe <deathaxe82@googlemail.com> Co-authored-by: Raoul Wols <raoulwols@gmail.com>
predragnikolic
added a commit
that referenced
this pull request
Apr 20, 2024
…2446) * "Add .python-version file" * remove pathlib from dependencies * change import * Revert "change import" (: This reverts commit c70cd57. * Fix failing unittests on MacOS (#2436) This commit adopts `unittesting.ViewTestCase` to run view related test cases. ViewTestCase ... 1. provides `view` and `window` members pointing to a dedicated view, being created for testing. 2. ensures not to close empty windows, which was probably the most likely reason for unittests failing before on MacOS. * keep the same order as before * rchlint * add release notes * Import from enum and typing modules * Keep using fake enums * Import remaining classes from typing_extensions * Fix enum types and import from enum module * Quoted type annotation not needed anymore with the ParamSpec from typing_extensions --------- Co-authored-by: Предраг Николић <idmpepe@gmail.com> Co-authored-by: Rafal Chlodnicki <rafal@squareup.com> Co-authored-by: deathaxe <deathaxe82@googlemail.com> Co-authored-by: Raoul Wols <raoulwols@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adopts
unittesting.ViewTestCaseto run view related test cases.ViewTestCase ...
viewandwindowmembers pointing to a dedicated view, being created for testing.