optimize creation of code actions annotation region #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround a pathological case where server returns hundreds of code actions for the selection and causes ST's memory usage to explode when creating code actions annotation region.
Instead of creating a huge link that includes whole code action response, use response stored in the local
self._actions_by_config. This was already the case when using "bulb" for code actions so apart from fixing the memory issue, it makes code more consistent.Also small optimization to remove local
action_listsandall_actionsvariables that weren't really used for anything and just increased heap memory usage.