Fix prepareRename support #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
commented
Dec 3, 2022
Comment on lines
-45
to
-57
| # mypy: Signature of "is_enabled" incompatible with supertype "LspTextCommand" | ||
| def is_enabled( # type: ignore | ||
| self, | ||
| new_name: str = "", | ||
| placeholder: str = "", | ||
| position: Optional[int] = None, | ||
| event: Optional[dict] = None, | ||
| point: Optional[int] = None | ||
| ) -> bool: | ||
| if self.best_session("renameProvider.prepareProvider"): | ||
| # The language server will tell us if the selection is on a valid token. | ||
| return True | ||
| return super().is_enabled(event, point) |
There was a problem hiding this comment.
This was redundant and it's enough to use base implementation.
When this code was introduced it looked a bit differently and it made sense then.
Comment on lines
+97
to
+99
| listener = self.get_listener() | ||
| if listener: | ||
| listener.purge_changes_async() |
There was a problem hiding this comment.
I've added "purge" because I've noticed an issue with lsp-typescript where it requests client to apply edits and immediately triggers rename before client has triggered "didChange".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with the old code was that it has shown the input overlay asking for new name before sending the
prepareRenamerequest and didn't use the range (or placeholder) from the response.Added big comment about how
lsp_symbol_renameworks since it behaves very differently depending on if server supports prepareRename request.Related to sublimelsp/LSP-typescript#178