Combine file and range formatting entries in context menu

[jwortmann]

This is a first step towards cleaning up the context menu (#1983) by combining "Format File" and "Format Selection" into a single item with dynamic label. It also makes the question obsolete whether "Format File" should be included in the context menu or if the main menu entry is enough (#2066 (comment)).

[rchl]

BTW. Should same treatment be applied to the main menu item (in Edit menu)?

[jwortmann]

I didn't adjust the main menu, because in contrast to the context menu, space limitation is not a significant factor in the main menu. In theory, with the current main menu you could still choose to format the whole file, even if there is a selection in the view (though I'm not sure if anybody would actually want to do this).

Personally I don't have any objections to change it in the main menu too, and make it consistent with the context menu. Then the command palette entries should probably be adjusted as well?

LSP/Default.sublime-commands

Lines 56 to 63 in 658fcfe

	{
	"caption": "LSP: Format File",
	"command": "lsp_format_document",
	},
	{
	"caption": "LSP: Format Selection",
	"command": "lsp_format_document_range",
	},

---

Btw I just saw that the command palette has "Goto Declaration" and "Goto Implementation", but not "Goto Definition" or "Find References".

[rchl]

I don't have super strong opinion about it but I would lean towards consistency everywhere.

Btw I just saw that the command palette has "Goto Declaration" and "Goto Implementation", but not "Goto Definition" or "Find References".

I've noticed it before and it seemed wrong to me.