Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary is_range_equal function #2114

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Remove unnecessary is_range_equal function #2114

merged 1 commit into from
Nov 4, 2022

Conversation

jwortmann
Copy link
Member

Python has this actually built-in for dict/TypedDict.

rchl
rchl approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@rchl rchl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it's a remnant from the times when we had a Range class.

EDIT: no, nevermind, I've added it when switching from class...

@rchl rchl changed the title Remove is_range_equal function Remove unnecessary is_range_equal function Nov 4, 2022
@rchl rchl merged commit fe9fbd1 into sublimelsp:main Nov 4, 2022
@jwortmann jwortmann deleted the remove-is_range_equal branch November 4, 2022 21:02
rchl added a commit that referenced this pull request Jan 16, 2023
@rchl
Merge branch 'main' into feat/diag-annotations
9b9fc0b 
* main:
  Don't trigger code action requests for background views (#2108)
  Ignore diagnostics for files in folder_exclude_patterns (#2113)
  Remove unnecessary is_range_equal function (#2114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchl rchl rchl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwortmann @rchl