Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add LSP-clangd and LSP-terraform to Language Servers #2096

Merged
merged 2 commits into from
Oct 23, 2022
Merged

Docs: Add LSP-clangd and LSP-terraform to Language Servers #2096

merged 2 commits into from
Oct 23, 2022

Conversation

rchl
Copy link
Member

@rchl rchl commented Oct 22, 2022 •
edited
Loading

Docs changes

  • Add LSP-clangd and LSP-terraform to Language Servers
  • Remove C++ guide as it's covered in more concise form by LSP-clangd's readme
  • Move /guides/client_configuration to /client_configuration as it's the only "guide" at this point
  • Set up redirects so that old URLs still work/redirect

Related to sublimelsp/LSP-clangd#1

@rchl rchl mentioned this pull request Oct 22, 2022
Merged
predragnikolic
predragnikolic reviewed Oct 23, 2022
View reviewed changes
docs/mkdocs.yml
- Language Servers: language_servers.md
- Features: features.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice change!

predragnikolic
predragnikolic approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@predragnikolic predragnikolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Redirects ✔️

Just notices this small thing
https://github.com/sublimelsp/LSP/pull/2096/files#r1002673654

@predragnikolic predragnikolic merged commit 5fdcbf6 into main Oct 23, 2022
@predragnikolic predragnikolic deleted the fix/lsp-clang branch October 23, 2022 13:54
@predragnikolic
Copy link
Member

predragnikolic commented Oct 30, 2022 •
edited
Loading

For some reason the github action to build the docs wasn't run.
so I still see the old docs.

Wait the action run and there are some warnings about Node 12:
https://github.com/sublimelsp/LSP/actions/runs/3307316366

@rchl
Copy link
Member Author

rchl commented Oct 30, 2022

Don't think those deprecation warnings are relevant to the issue.
Deployment is happening from the gh-pages branch: https://github.com/sublimelsp/LSP/actions/runs/3354949410/jobs/5558959354
I'll try to restart the failed job there.

@rchl
Copy link
Member Author

rchl commented Oct 30, 2022

https://github.com/sublimelsp/LSP/settings/environments/51262986/edit didn't white list gh-pages branch. Should be good now.

@predragnikolic
Copy link
Member

You fixed it :D how?

rchl added a commit that referenced this pull request Jan 16, 2023
@rchl
Merge branch 'main' into feat/diag-annotations
e0e41c8 
* main:
  Docs: Add LSP-clangd and LSP-terraform to Language Servers (#2096)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@predragnikolic predragnikolic predragnikolic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchl @predragnikolic