Focus symbol closest to selection on showing document symbols #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
commented
Oct 21, 2022
| @@ -109,13 +108,22 @@ def handle_response(self, response: Union[List[DocumentSymbol], List[SymbolInfor | |||
| self.view.settings().erase(SUPPRESS_INPUT_SETTING_KEY) | |||
| window = self.view.window() | |||
| if window and isinstance(response, list) and len(response) > 0: | |||
| panel_items = self.process_symbols(response) | |||
There was a problem hiding this comment.
I hate code that creates side effects (self.regions) and also returns something but decided not to refactor anything here.
rchl
commented
Oct 21, 2022
Comment on lines
-149
to
-151
| if self.is_first_selection: | ||
| self.is_first_selection = False | ||
| return |
There was a problem hiding this comment.
We had code that prevented scrolling to selected symbol on opening the quick panel but with this behavior change I think it's no longer needed. Otherwise the behavior would be inconsistent as the outline would not show initially but only after changing selection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match ST behavior and focus symbol closest to selection on triggering Go to Symbol command.
Taking end point of first selection and finding symbol that intersects it or is just before it.
I think ST might have slightly different behavior with multiple selections (takes into account last while we take first) but otherwise it should match ST behavior.
Fixes #2093