Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable Goto Diagnostic commands if diagnostic with configured severity exists #2091

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Only enable Goto Diagnostic commands if diagnostic with configured severity exists #2091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions plugin/goto_diagnostic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,16 @@ def is_enabled(self, uri: Optional[DocumentUri] = None, diagnostic: Optional[dic
uri = uri_from_view(view)
except MissingUriError:
return False
max_severity = userprefs().diagnostics_panel_include_severity_level
if uri:
parsed_uri = parse_uri(uri)
return any(parsed_uri in session.diagnostics for session in get_sessions(self.window))
return any(bool(session.diagnostics) for session in get_sessions(self.window))
return any(diagnostic for session in get_sessions(self.window)
for diagnostic in session.diagnostics.diagnostics_by_parsed_uri(parsed_uri)
if is_severity_included(max_severity)(diagnostic))
return any(diagnostic for session in get_sessions(self.window)
for diagnostics in session.diagnostics.values()
for diagnostic in diagnostics
if is_severity_included(max_severity)(diagnostic))

def input(self, args: dict) -> Optional[sublime_plugin.CommandInputHandler]:
uri, diagnostic = args.get("uri"), args.get("diagnostic")
Expand Down