fix issues with restarting servers #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can confirm that this does fix this issue. |
predrag-codetribe
approved these changes
Oct 18, 2022
|
I don't know who you are but I'll take it ;) |
rchl
added a commit
that referenced
this pull request
Oct 18, 2022
* origin/main: fix issues with restarting servers (#2088)
rchl
added a commit
that referenced
this pull request
Jan 16, 2023
* main: Focus symbol closest to selection on showing document symbols Properly handle disabling of the LSP package (#2085) fix issues with restarting servers (#2088) Add `$line` and `$character` expansion variables (#2092) Only enable Goto Diagnostic commands if diagnostic with configured severity exists (#2091) Update diagnostics gutter icons and change default to "sign" (#2086) Fix short color box rendering bug after color presentation change (#2087)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were issues with restarting servers when there were more than one views using the same session and the corresponding server was restarted. Only the active view would start the session again and on other views the session would not start.
Fixed by using
WindowManager.restart_sessions_asyncwhich re-registers all view listeners rather than the (internal)WindowManager._end_sessions_asyncand manually registering just the active view listener.Also removed unnecessary
WindowManager._end_sessions_asynccall after disabling server globally as ending the sessions is already handled on disabling the config (saving settings).