Remove Range class and rename RangeLsp to Range #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwols
approved these changes
Sep 17, 2022
|
@jwortmann I'll wait for your OK or acknowledgement at least. |
predragnikolic
approved these changes
Sep 17, 2022
I welcome this PR very much 😄 |
rchl
added a commit
that referenced
this pull request
Sep 27, 2022
* main: Fix issues with diagnostics panel toggling on save (#2063) Request color presentations when clicking on a color box (#2065) Import new imports like NotRequired from "typing" Ensure "Source Actions..." request includes the "source" kind (#2064) refactor(types): Mark properties with NotRequired (#2062) Add template variable `$text_document_position` in execute command (#2061) Only update content of diagnostics panel when visible (#2054) Remove Range class and rename RangeLsp to Range (#2058)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @jwortmann in #2049 (comment) and also to make migration to new types much easier, renamed
RangeLsptoRangeand removed our customRangeclass. It was an unnecessary intermediate class that wasn't really used for much (itscontains,intersects,extendmethods weren't even used outside of tests).