Improve strategy for semantic highlighting requests #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If a very big file was just opened, initially request tokens only for the visible range (if the server supports it), and after the response arrives also request tokens for the rest of the file. This way semantic highlighting can be shown faster for the currently visible part of the file, and for the rest of the file it will be applied a little bit later. * If the server supports only the semanticTokens/range request, use the entire file range for the requested content range while typing. By doing this, semantic highlighting is also visible after scrolling the file and it prevents unpleasant highlighting updates when typing after scrolling to another position.
rchl
approved these changes
Aug 17, 2022
rwols
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small optimization for semantic highlighting:
If a very big file was just opened, initially request tokens only for
the visible range (if the server supports it), and after the response
arrives also request tokens for the rest of the file. This way
semantic highlighting can be shown faster for the currently visible
part of the file, and for the rest of the file it will be applied a
little bit later.
If the server supports only the semanticTokens/range request, use the
entire file range for the requested content range while typing. By
doing this, semantic highlighting is also visible after scrolling the
file and it prevents unpleasant highlighting updates when typing after
scrolling to another position.
With LSP-lua and a 165kb file:
Before:
Click to show GIF
Time between request send and response arrives (counted from screen record with 60Hz): 166 frames = 2.77 sec
After:
Click to show GIF
Time between request send and response arrives: 13 frames = 0.22 sec