-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove registration of the legacy LanguageHandler class #1936
Conversation
I can't find any package any more that still uses this.
I guess only these 2 plugins that are published on PC still use LanguageHandler: https://github.com/prometheus-community/sublimelsp-promql/blob/master/plugin.py#L130 (not part of the LSPSublimeOrg) |
Will you also delete the |
LSP-Serenata hasn't updated for 2 years (still using an old server) and the server, Serenata was last active commit in 10 months ago. Consider PHP is evolving every year, I may assume both of LSP-Serenata and Serenata are gradually outdated... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In boot.py
those are unused:
- import weakref
Callable
andTuple
from.plugin.core.typing
Also maybe we should be defining __all__
to clearly indicate which imports are "public". That would also get rid of all false positive warnings that import is "unused".
I can't find any package any more that still uses this.