Fix console exception with panel logger enabled

[rchl]

After window is closed, the server messages can keep coming for a while
and the "is_valid()" check doesn't really work as expected for closed
Window so we need to do the "is in" check instead.

[rchl]

When checking the "Window.is_valid()" in the console it seems to work but I guess there is a small time frame after the tab is removed where it will still be reporting is_valid() == True

[predragnikolic]

and the "is_valid()" check doesn't really work as expected for closed

is this a ST bug?

For me this PR looks like it adds additional logic, but the benefit is not so obvious.
Was there a reason for this PR? (some bug, degraded performance issue of some sort)

[rchl]

and the "is_valid()" check doesn't really work as expected for closed

is this a ST bug?

For me this PR looks like it adds additional logic, but the benefit is not so obvious. Was there a reason for this PR? (some bug, degraded performance issue of some sort)

I often see exceptions in the console when the server starts in some window and I close the window soon after it started. The WindowPanelListener.server_log_map[window_id] throws because given window_id was already removed from the map.

It's not necessarily a bug in ST. We are removing the id from the map from on_pre_close_window so technically it can still be valid for a while after we've removed it.