Fix the LSP Development command
#1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwols
requested changes
Jun 4, 2021
There was a problem hiding this comment.
can you instead use this?
diff --git a/plugin/tooling.py b/plugin/tooling.py
index 9bcdc6f..21febe0 100644
--- a/plugin/tooling.py
+++ b/plugin/tooling.py
@@ -1,4 +1,5 @@
from .core.css import css
+from .core.logging import debug
from .core.registry import windows
from .core.sessions import get_plugin
from .core.transports import create_transport
@@ -41,7 +42,12 @@ def _preprocess_properties(translations: Optional[Dict[str, str]], properties: D
- Replace description translation placeholders by their English translation
- Discard the "scope" key
+ - Removes key/values whose value is not a dict
"""
+ non_dict_keys = [k for k, v in properties.items() if not isinstance(v, dict)]
+ for k in non_dict_keys:
+ debug("discarding key:", k)
+ properties.pop(k)
for v in properties.values():
v.pop("scope", None)
descr = v.get("description")
rwols
requested changes
Jun 5, 2021
rchl
reviewed
Jun 5, 2021
rchl
approved these changes
Jun 5, 2021
rwols
approved these changes
Jun 5, 2021
| @@ -161,6 +167,8 @@ def run(self, base_package_name: str) -> None: | |||
| self.view.assign_syntax("Packages/JSON/JSON.sublime-syntax") | |||
| self.writeline("{") | |||
| for k, v in sorted(properties.items()): | |||
| if not isinstance(v, dict): | |||
There was a problem hiding this comment.
I don’t think this check is actually necessary now. But better safe than sorry I suppose :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix the tooling command for generating a schema is fixed. As discussed in the discord server!. Just adds a few is-instance checks!