Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle percent-encoding and leading slash in file URIs #1722

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Handle percent-encoding and leading slash in file URIs #1722

merged 2 commits into from
Jun 4, 2021

Conversation

jwortmann
Copy link
Member

... when used in Markdown link destinations in hover popups.

Resulting from the discussion in #1711.

I've only tested on Windows.

jwortmann added 2 commits June 4, 2021 15:47
@jwortmann
Handle percent-encoding and leading slash in file URIs
37f8120 
... when used in Markdown link destinations in hover popups.
@jwortmann
Decode the whole URI
614f3a5
rwols
rwols approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@rwols rwols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can take a look at plugin/core/url.py as well? The logic there is incorrect for UNC paths like \\192.168.0.100\foo\bar from what I remember.

@rwols rwols merged commit e482b62 into sublimelsp:main Jun 4, 2021
@jwortmann jwortmann deleted the file-uri branch June 4, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwols rwols rwols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwortmann @rwols