Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hover code actions UX #1686

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Conversation

husanjun
Copy link
Contributor

@husanjun husanjun commented May 27, 2021

  1. If only one, If the action link is clicked, it is ran immediately, circumventing the quick panel.
    image

  2. If only diagnostics, don't show navigation
    image

  3. Improved hover phantom problem

BTW, When hovering, the code action does not just occur during the diagnosis

plugin/hover.py Outdated Show resolved Hide resolved
plugin/hover.py Outdated Show resolved Hide resolved
plugin/hover.py Outdated Show resolved Hide resolved
plugin/hover.py Outdated Show resolved Hide resolved
plugin/hover.py Show resolved Hide resolved
@husanjun husanjun mentioned this pull request May 28, 2021
plugin/documents.py Outdated Show resolved Hide resolved
plugin/hover.py Show resolved Hide resolved
@rchl
Copy link
Member

rchl commented May 28, 2021

  1. If only one, If the action link is clicked, it is ran immediately, circumventing the quick panel.
    image

That code action title can look like just some random text there, depending on what it says, I feel.
Maybe we should prefix it with Code action:?

@husanjun
Copy link
Contributor Author

  1. If only one, If the action link is clicked, it is ran immediately, circumventing the quick panel.
    image

That code action title can look like just some random text there, depending on what it says, I feel.
Maybe we should prefix it with Code action:?

Do you mean?
image

@rchl
Copy link
Member

rchl commented May 28, 2021

Yes.
Lets discuss this first before doing any changes but something like that, yes. Ideally with a space after the colon :)

plugin/documents.py Outdated Show resolved Hide resolved
@rwols
Copy link
Member

rwols commented May 31, 2021

Please merge with main and resolve the merge conflicts.

Copy link
Member

@rwols rwols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it out

@rwols rwols merged commit c483402 into sublimelsp:main Jun 1, 2021
@husanjun husanjun deleted the hover-action branch June 8, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants