Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix completion docs not showing for servers that are not resolve providers #1610

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Fix completion docs not showing for servers that are not resolve providers #1610

merged 2 commits into from
Mar 11, 2021

Conversation

rwols
Copy link
Member

@rwols rwols commented Mar 10, 2021

No description provided.

@predragnikolic
Copy link
Member

Hmm, the return statement was added to fix #1582 (comment)

@rchl
Copy link
Member

rchl commented Mar 11, 2021

Yeah, should keep the return and just make sure that self.handle_resolve_response_async is called in all cases.

@rwols rwols merged commit 9e67e96 into st4000-exploration Mar 11, 2021
@rwols rwols deleted the fix/completion-docs branch March 11, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchl rchl rchl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwols @predragnikolic @rchl