Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change popup style #1574

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Change popup style #1574

merged 3 commits into from
Feb 11, 2021

Conversation

predragnikolic
Copy link
Member

closes #1566

This PR makes all the font-size of header elements the same as the other text(1rem).
But header elements are bold, which makes them standout just enough from the rest of the text.

Header font size before:
headers

Header font size after:
the smallest


I also reduced the hr margin to be consistent with the popup margin spacing (0.5)

Before:
big

After
smaller

Copy link
Member

@rwols rwols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@predragnikolic
Copy link
Member Author

There was a comment from Rafal :)

I would think that using the same size for all of them could make the content harder to read in case it's structured with multiple different heading levels. - #1566 (comment)

Having different sizes for different headers makes sense for a web page,
but I don't think that having different font-sizes for header would improve readability, because of the limited space in the popup.

@rchl
Copy link
Member

rchl commented Feb 11, 2021

I'm fine with trying it but would it make sense to at least make them a little bit bigger than normal text? Maybe 1.1rem for all?

(I can't currently find any content I could test this with so maybe it's not that important either way ;))

popups.css Outdated Show resolved Hide resolved
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
@predragnikolic
Copy link
Member Author

There is really a small difference between 1.1rem and 1rem.

smallerheader

the smallest

I initially chose 1rem because a little more text is visible :)

@rwols rwols merged commit 905dd29 into st4000-exploration Feb 11, 2021
@rwols rwols deleted the change-popup-style branch February 11, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make header font-size same as text in popups
3 participants