Replace Diagnostic by a TypedDict #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't looked at the changes but have a question. Are your changes compatible with the use-case where the user doesn't use the diagnostic panel but just wants to navigate the diagnostics shown in the view? You said that you are relying on native next/previous_result but doesn't that require the results to be visible in the panel? |
No. this works even when the panel is not visible :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #1527, simplify a lot of the code.
Replacing Diagnostic by a TypedDict made me rethink the "next/prev diagnostic" functionality. I'm convinced it can just as well be done with the existing popup code using ST's built-in F4 (
next_result) and shift+F4 (prev_result). This has the major advantage of having much less code to maintain. As well as not having to account for two different ways to render a diagnostic to minihtml.It's quite a bit of changes. If you want to inspect it I'd suggest looking at the two commits separately as they should be stand-alone.