Use the system font for header elements in popups

[rwols]

No description provided.

[rchl]

What kind of content uses header elements and should we really apply those to all headers, even ones that come from a server? Or should we even just apply that font style to the whole popup? At this point, I'm not sure what doesn't use it since the p element does which is probably used in a lot of places.

[rwols]

What kind of content uses header elements and should we really apply those to all headers, even ones that come from a server?

<h1> is used a lot by clangd.

Or should we even just apply that font style to the whole popup?

I would say yes, but I don't know how to do that in a neat way, because I suck at css.

[rchl]

I would say yes, but I don't know how to do that in a neat way, because I suck at css.

So we could just have a font-family: system; in the top .lsp_popup selector. That will be inherited by all children unless something overrides font-family (or font, if ST supports that) to something else. Also, ST's internal styles might override it if those specify font-family for certain elements. But I don't know if they do.

But we can just have font-family on the top selector and if it doesn't apply to something then make a specific override for that.

[rwols]

Hmm... this also styles the diagnostics with the system font. I don't think that's an improvement.

[rchl]

It feels a bit random to me in which font-family style we style what. We target certain element types rather than certain content types.

But I guess it should be fine, we can think of a more generic solution later.

[rwols]

I managed to simplify it I think :) or can something go wrong with this?

[rwols]

I'm not sure how to "reset" the font-family here. The value monospace doesn't actually do what it is supposed to do: #1171 (comment)

[rchl]

You are referring to a deleted line?
Not sure what do you exactly mean since the code doesn't look like that anymore.

[rwols]

I wrote font-family: monospace; here, but that doesn't actually work as you'd expect. It just so happens to work. But the behavior is unconfirmed on Windows.

The only special font-family is presumably system.